WIP Adding a toggleable additional Gitea external mirror #2071
Conversation
craddm
added
the
enhancement
| class SREGiteaExternalServerComponent(ComponentResource): | ||
| """Deploy Gitea server with Pulumi""" |
There was a problem hiding this comment.
There's a lot of overlap between this and the SREGiteaServerComponent. Can we combine both into a single reusable component?
There was a problem hiding this comment.
Yes, that's what I'm actually doing, I just haven't pushed yet
| if props.gitea_servers == GiteaServers.BOTH: | ||
| gitea_servers = ["external", "internal"] | ||
| else: | ||
| gitea_servers = ["internal"] |
There was a problem hiding this comment.
| if props.gitea_servers == GiteaServers.BOTH: | |
| gitea_servers = ["external", "internal"] | |
| else: | |
| gitea_servers = ["internal"] | |
| gitea_servers = ["external", "internal"] if (props.gitea_servers == GiteaServers.BOTH) else ["internal"] |
not sure this is clearer though
There was a problem hiding this comment.
I'm also switching to using a boolean True/False for deploying the external mirror anyway, as we'd (presumably) always want the internal one anyway
There was a problem hiding this comment.
Sounds like I should stop commenting on your WIP PR 😆
There was a problem hiding this comment.
Already some good points to nip some things in the bud 😆
| ldap_server_hostname=props.ldap_server_hostname, | ||
| ldap_server_port=props.ldap_server_port, | ||
| ldap_username_attribute=props.ldap_username_attribute, | ||
| ldap_user_filter=props.ldap_user_filter, | ||
| ldap_user_search_base=props.ldap_user_search_base, |
There was a problem hiding this comment.
We probably don't want don't need the external server to plug in to our LDAP directory.
There was a problem hiding this comment.
Some notes on Gitea configuration here
|
One other thing to consider - you'll probably want the external mirror deployed into its own subnet so that we can set the networking rules accordingly (external one will be allowed internet access but no access from workspaces; internal one will have no internet access but access allowed from workspaces). |
craddm
force-pushed
the
gitea_external_mirror
branch
from
50e9c1e
to
599f771
Compare
✅ Checklist
Enable foobar integrationrather than515 foobar).develop.🚦 Depends on
Adds an optionally deployable second Gitea instance intended for use as an external mirror that can then be accessed via the internal Gitea instance.
🌂 Related issues
Relates to milestone for release 5.1.0 an all Gitea issues e.g. #1998
🔬 Tests
Ongoing